feat(desktop): add Back and Forward buttons to the titlebar by saphid · Pull Request #15071 · pingdotgg/t3code

saphid · 2026-10-03T06:41:11Z

Problem

The desktop app has no Back or Forward buttons. #13212 added navigation.back / navigation.forward (mod+[ / mod+]), but there is nothing to click and no hint the shortcuts exist. Browsers already have their own buttons, so this only affects the desktop window.

Change

Adds Back and Forward buttons to the desktop titlebar, right of the sidebar toggle. They do the same thing as the shortcuts, and their tooltips show the shortcut.

Back is enabled when there is an earlier entry, using TanStack Router's useCanGoBack.
Forward is enabled after you go back. Browsers don't report how many entries are ahead, so navigationHistory.ts tracks the furthest entry reached since the last push. A new push clears Forward, and replace keeps it. Tracking starts when the router is created. The position is saved in sessionStorage with the current entry's key, so reloading the window keeps Forward; a fresh document ignores it.
The titlebar content inset now leaves room for the two extra buttons, so the chat and settings headers clear them when the sidebar is collapsed.
The sidebar brand can now shrink and clip inside a narrow sidebar instead of overlapping the main header. (The earlier per-platform pill breakpoint was dropped on rebase: main now wraps the environment pill onto a clipped second line when it does not fit, which covers the same case.)

Web is unchanged.

Opening Settings, then clicking Back and Forward (after, c6df7ad). Back enables after the push. After going back, Forward enables and Back disables. Forward then returns to Settings:

More states

Collapsed sidebar, before and after. The header clears all three buttons:

Back tooltip:

840 px window (narrowest sidebar). The brand clips inside the sidebar instead of overlapping the header:

Flow as MP4

Scope and approval

This is the narrower follow-up @juliusmarminge invited when closing #8727 in favor of #13212: "Feel free to reopen a narrower follow-up if you still want chrome back/forward buttons or the mobile header controls from this PR." This PR covers only the desktop titlebar buttons. Mobile header controls are not included.

Verification

vp test run apps/web/src/navigationHistory.test.ts apps/web/src/keybindings.test.ts: 139 passed. The new tests use a real memory history and cover Forward after going back, a push clearing Forward, a replace keeping it, an untracked history, restoring Forward for the same entry after a reload, and ignoring a stored position from another entry.
vp run typecheck in apps/web passed. vp lint on the changed files passed, apart from one existing set-state-in-effect warning in AppSidebarLayout.tsx.
Desktop dev build (vp run dev:desktop, macOS, disposable worktree state with one project and one thread). Driven over the Electron remote-debugging port with real mouse events. Observed: both buttons disabled at start; Back enabled after opening Settings; Forward enabled after Back; Forward disabled again after Forward; tooltip text; collapsed-sidebar layout; 840 px window. Before shots are from main at 151c241 in the same build and window. On a31f263 I also checked that after Settings → Back → reload, Forward stays enabled and still works.
The media was captured on c6df7ad. a31f263 doesn't change what it shows: the pill change only affects Windows and Linux, and this window uses artwork, not the pill. The reload persistence is a check, not media.
Independent review by Codex GPT-6.1-Sol (high reasoning), run three times. Round 1 found the brand overlap at narrow widths, fixed in c6df7ad. Round 2 found the pill hidden on Windows/Linux and Forward lost on reload, both fixed in a31f263. Round 3 on the full diff found no actionable issues.

Limits:

Screenshots are of the page contents captured through DevTools, so the macOS traffic lights don't appear. The 90 px inset they occupy is still there.
The flow GIF is sampled at about 9 fps from back-to-back screenshots. It shows the states, not animation smoothness.
Not checked on Windows or Linux desktop builds.

Built with Claude Opus 5.5 in Claude Code (via T3 Code). Independent review by Codex GPT-6.1-Sol.

macroscopeapp · 2026-10-03T06:43:10Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds always-on Electron titlebar Back and Forward controls and a new route-history/sessionStorage tracker, along with related titlebar layout behavior. Because it introduces user-facing desktop functionality and production navigation state behavior rather than an off-by-default option, human review is warranted.

^{You can add or adjust custom eligibility rules. Learn more.}

coderabbitai · 2026-10-03T06:53:28Z

Warning

Review limit reached

Only developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing.

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.config.ts
Review profile: CHILL
Plan: Advanced
Run ID: d8b405f8-1a3c-4d58-810c-c7e32dfb90f9

📥 Commits

Reviewing files that changed from the base of the PR and between a31f263 and 5c5641a.

📒 Files selected for processing (5)

apps/web/src/components/AppSidebarLayout.tsx
apps/web/src/components/sidebar/SidebarChrome.tsx
apps/web/src/navigationHistory.test.ts
apps/web/src/navigationHistory.ts
apps/web/src/router.ts

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: b9d475e7-c1c2-4009-9a19-e4a7566257b7

📥 Commits

Reviewing files that changed from the base of the PR and between fed41fa and a31f263.

📒 Files selected for processing (5)

apps/web/src/components/AppSidebarLayout.tsx
apps/web/src/components/sidebar/SidebarChrome.tsx
apps/web/src/navigationHistory.test.ts
apps/web/src/navigationHistory.ts
apps/web/src/router.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

The router now tracks the furthest navigation index, and Electron sidebar titlebars provide Back and Forward controls. Sidebar layout and branding behavior also adjust for backdrop placement and platform-specific widths.

Changes

Electron navigation controls

Layer / File(s)	Summary
Track navigation history `apps/web/src/navigationHistory.ts`, `apps/web/src/router.ts`, `apps/web/src/navigationHistory.test.ts`	Router creation starts history tracking. Tracking records the furthest index, persists it in session storage when possible, and exposes Forward availability. Tests cover navigation actions, untracked histories, and stored-index restoration.
Add sidebar history controls `apps/web/src/components/AppSidebarLayout.tsx`, `apps/web/src/components/sidebar/SidebarChrome.tsx`	Electron titlebars show Back and Forward buttons with availability-based disabled states and shortcut labels. The sidebar trigger and titlebar offset account for backdrop placement and control width. The environment pill threshold changes on macOS Electron, and the brand link can shrink.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant getRouter
  participant trackNavigationHistory
  participant RouterHistory
  participant SessionStorage
  participant NavigationHistoryControls
  getRouter->>trackNavigationHistory: Start tracking RouterHistory
  trackNavigationHistory->>RouterHistory: Subscribe to navigation changes
  trackNavigationHistory->>SessionStorage: Read or persist furthest index
  NavigationHistoryControls->>RouterHistory: Read forward availability

Suggested reviewers: stienswout, juliusmarminge

Merge Risk: ⚪ Minimal · up to a31f2

The desktop navigation controls appear ready to merge after normal checks; no actionable blocking issue is established.

Security Architecture Review

Security architecture risk: 🔵 Low · up to a31f2

The buttons use existing navigation capabilities without introducing new destinations or privileges. Remaining uncertainty concerns history restoration and lifecycle behavior, rather than a demonstrated security weakness.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

inferred — The demonstrated effect is bounded to navigation availability in the current renderer history. The new controls do not establish additional tenant, service, credential, or infrastructure authority beyond the existing navigation path.

Security Findings and Attack Paths

inferred — A writer able to modify the same session-storage record could supply a matching key and inflated integer to falsely enable Forward. The value is never passed as a navigation target; the handler still invokes the existing one-step history operation. This establishes possible misleading availability, not increased navigation authority.

Trust Boundaries and Controls

observed — Stored state must match the current entry key before restoration. UI controls remain Electron-gated and disable unavailable directions; navigation execution remains delegated to router history.

Resilience and Maintainability Implications

inferred — The document-scoped initialization and per-history guard limit duplicate observers during normal startup. Tracker subscription cleanup is not explicit, but no repeated production router lifecycle was demonstrated in the inspected initialization path.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 15.38% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 5 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly describes the main change: adding Back and Forward buttons to the desktop titlebar.
Description check	✅ Passed	The description includes all required sections. It explains the problem and change, identifies the approval context and scope, and gives specific test results, manual verification details, evidence, a…

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

saphid · 2026-10-03T06:54:24Z

Re the CodeRabbit docstring-coverage warning: not adding boilerplate docstrings. AGENTS.md asks for comments that describe how a thing is used, and the new module and controls already carry those. No actionable review findings remain on a31f263.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

macroscopeapp · 2026-10-06T16:37:11Z

+    // Titlebar content clears the sidebar toggle plus the Back and Forward controls.
+    ...(isElectron
+      ? {
+          "--workspace-titlebar-content-left":


Tailwind in the owning component: This static titlebar inset belongs in a conditional Tailwind arbitrary-property class on the sidebar provider, rather than in sidebarProviderStyle.

^{Posted via Macroscope — UI Consistency}

saphid · 2026-10-06T16:47:46Z

Review requested

Date (UTC)	Reviewer	Where
2026-10-06	Maria	Discord DM

_{Logged so this PR shows when a maintainer was asked to review it.}

github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Oct 3, 2026

juliusmarminge added the macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews label Oct 3, 2026 — with ChatGPT Codex Connector

saphid force-pushed the feat/titlebar-nav-buttons branch from a31f263 to ff9540d Compare October 6, 2026 11:33

saphid and others added 3 commits October 7, 2026 03:32

feat(desktop): add Back and Forward buttons to the titlebar

fc03949

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

fix(desktop): keep the sidebar brand inside narrow sidebars

694dc7b

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

fix(desktop): keep Forward across reloads and the pill on Windows/Linux

5c5641a

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

saphid force-pushed the feat/titlebar-nav-buttons branch from ff9540d to 5c5641a Compare October 6, 2026 16:32

macroscopeapp Bot reviewed Oct 6, 2026

View reviewed changes

Navigation Menu

Repository navigation

feat(desktop): add Back and Forward buttons to the titlebar - #15071

feat(desktop): add Back and Forward buttons to the titlebar#15071
saphid wants to merge 3 commits into
pingdotgg:mainfrom
saphid:feat/titlebar-nav-buttons

saphid commented Oct 3, 2026 •

edited

Loading

Uh oh!

macroscopeapp Bot commented Oct 3, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 3, 2026 •

edited

Loading

Review limit reached

Walkthrough

Changes

Sequence Diagram(s)

❌ Failed checks (1 warning)

Uh oh!

saphid commented Oct 3, 2026

Uh oh!

macroscopeapp Bot Oct 6, 2026

Uh oh!

saphid commented Oct 6, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

saphid commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Change

Scope and approval

Verification

Uh oh!

macroscopeapp Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

coderabbitai Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Sequence Diagram(s)

Security Architecture Review

❌ Failed checks (1 warning)

Uh oh!

saphid commented Oct 3, 2026

Uh oh!

macroscopeapp Bot Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

saphid commented Oct 6, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

saphid commented Oct 3, 2026 •

edited

Loading

macroscopeapp Bot commented Oct 3, 2026 •

edited

Loading

coderabbitai Bot commented Oct 3, 2026 •

edited

Loading